docs: adding cbroti requirement for custom caddy build. #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenMiracle
changed the title
dunglas
requested changes
Mar 4, 2024
|
Good catch. We need to use Go build directives to not have a hard dependency on cbrotli. I'll do that but let's update the docs in the meantime. |
dunglas
approved these changes
Mar 4, 2024
|
Thanks! |
|
Ah. Thanks for updating back the asterisks. I just went to change. VS Code autoformatter. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was failing to build and run correctly without this module. The caddyfile shows the br encoding.